Skip to content

Conversation

ntindle
Copy link
Owner

@ntindle ntindle commented Aug 23, 2025

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring

Related Issue

Fixes #(issue number)

Changes Made

Testing

  • All existing tests pass
  • Added new tests for new functionality
  • Tested manually in browser
  • Tested with different drawer dimensions
  • Tested with custom printer settings
  • Tested with half-size bins enabled/disabled

Screenshots

Checklist

  • My code follows the project's code style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have used unitMath service for all calculations (no native JS math operations)
  • I have used @/ import paths consistently

ntindle and others added 3 commits August 11, 2025 00:15
TruffleHog fails on main branch pushes when BASE and HEAD are the same.
This change restricts it to only run on PRs where it can properly compare changes.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
- Upgraded both workflows to use Claude Opus 4.1 for better analysis
- Added comprehensive permissions for repository interaction
- Configured extensive allowed_tools for testing and verification
- Added project-specific custom instructions focusing on:
  - MathJS unitMath usage enforcement
  - TypeScript requirements
  - Code quality standards
- Enhanced PR review prompts with detailed criteria
- Added sticky comments for continuous PR review updates
- Configured environment variables for proper context

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Copy link

netlify bot commented Aug 23, 2025

Deploy Preview for gridfinity-drawer-planner ready!

Name Link
🔨 Latest commit 6877a06
🔍 Latest deploy log https://app.netlify.com/projects/gridfinity-drawer-planner/deploys/68a92d56dca7f200085dbc07
😎 Deploy Preview https://deploy-preview-31--gridfinity-drawer-planner.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: Nicholas Tindle <[email protected]>
Copy link

codecov bot commented Aug 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@f3eecab). Learn more about missing BASE report.
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage        ?   64.43%           
=======================================
  Files           ?       49           
  Lines           ?     3430           
  Branches        ?      319           
=======================================
  Hits            ?     2210           
  Misses          ?     1198           
  Partials        ?       22           
Flag Coverage Δ
unittests 64.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

PR Quality Report 📊

Check Status
TypeScript
ESLint
Tests
Build

View detailed results

@ntindle ntindle merged commit ac23b33 into main Aug 23, 2025
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant