Skip to content

Conversation

gbakeman
Copy link
Contributor

@gbakeman gbakeman commented Sep 9, 2022

  • New Nut_Exception constructor to allow specifying NUTResponse instead of _Exception_Value
  • Shifted some responsibility of error handling out of Socket class and into UPS class. These are some major changes and need testing.
  • Merged Create_Socket code into Connect code
  • Renamed and then commented-out IsKnownUPS function. Feels like this should be a part of the UPS class, but regardless, we'll know if there's an invalid UPS the moment a command is run for one.
  • Simplified & renamed Query_Desc function
  • Added a few events to the UPS class for informing any listeners of issues
  • UPS no longer handles socket errors, and instead passively notifies listeners about one
  • GetUPSVar supports DATA-STALE errors and will retry 3 times to get the data, and then take the default value and raise an event about the error.
  • If error is encountered when opening the ListVarGUI, display a message box and close the form.
  • Removed the Unknown_UPS event and modified the GUI to handle future errors.

Resolves #21

- New Nut_Exception constructor to allow specifying NUTResponse instead of _Exception_Value
- Shifted some responsibility of error handling out of Socket class and into UPS class. These are some major changes and need testing.
- Merged Create_Socket code into Connect code
- Renamed and then commented-out IsKnownUPS function. Feels like this should be a part of the UPS class, but regardless, we'll know if there's an invalid UPS the moment a command is run for one.
- Simplified & renamed Query_Desc function
- Added a few events to the UPS class for informing any listeners of issues
- UPS no longer handles socket errors, and instead passively notifies listeners about one
- GetUPSVar supports DATA-STALE errors and will retry 3 times to get the data, and then take the default value and raise an event about the error.
- If error is encountered when opening the ListVarGUI, display a message box and close the form.
- Removed the Unknown_UPS event and modified the GUI to handle future errors.
@gbakeman gbakeman added bug Something isn't working enhancement New feature or request labels Sep 9, 2022
@gbakeman gbakeman added this to the 2.2 Stable Release milestone Sep 9, 2022
@gbakeman gbakeman self-assigned this Sep 9, 2022
@gbakeman gbakeman linked an issue Sep 9, 2022 that may be closed by this pull request
@gbakeman gbakeman merged commit aa2342c into Dev-2.2 Sep 9, 2022
@gbakeman gbakeman deleted the 21-data-stale-response branch September 9, 2022 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when upsd sends DATA-STALE response
1 participant