Skip to content

fix(Table): use tr as separator #4083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 24, 2025
Merged

fix(Table): use tr as separator #4083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ab507c5
fix(Table): update styles for thead and th elements to show border fr…
larseberhardt May 5, 2025
24cacac
Merge remote-tracking branch 'origin/v3' into tableSafariBorderFix
larseberhardt May 19, 2025
90c78bc
fixes thead after element in safari
larseberhardt May 19, 2025
4d4940b
Merge remote-tracking branch 'origin/v3' into tableSafariBorderFix
larseberhardt May 19, 2025
f6ded41
Enhancement by closer to the original code
larseberhardt May 19, 2025
1aa7c27
Merge branch 'v3' into tableSafariBorderFix
benjamincanac May 22, 2025
5ce0ac5
Adds separate thead line for improved header styling
larseberhardt Jun 2, 2025
2d60fec
Merge branch 'v3' into tableSafariBorderFix
benjamincanac Jun 24, 2025
3d804cf
up
benjamincanac Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/runtime/components/Table.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,8 @@ defineExpose({
</slot>
</th>
</tr>

<tr :class="ui.separator({ class: [props.ui?.separator] })" />
</thead>

<tbody :class="ui.tbody({ class: [props.ui?.tbody] })">
Expand Down
5 changes: 3 additions & 2 deletions src/theme/table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,12 @@ export default (options: Required<ModuleOptions>) => ({
root: 'relative overflow-auto',
base: 'min-w-full overflow-clip',
caption: 'sr-only',
thead: 'relative [&>tr]:after:absolute [&>tr]:after:inset-x-0 [&>tr]:after:bottom-0 [&>tr]:after:h-px [&>tr]:after:bg-(--ui-border-accented)',
thead: 'relative',
tbody: 'divide-y divide-default [&>tr]:data-[selectable=true]:hover:bg-elevated/50 [&>tr]:data-[selectable=true]:focus-visible:outline-primary',
tr: 'data-[selected=true]:bg-elevated/50',
th: 'px-4 py-3.5 text-sm text-highlighted text-left rtl:text-right font-semibold [&:has([role=checkbox])]:pe-0',
td: 'p-4 text-sm text-muted whitespace-nowrap [&:has([role=checkbox])]:pe-0',
separator: 'absolute z-[1] left-0 w-full h-px bg-(--ui-border-accented)',
empty: 'py-6 text-center text-sm text-muted',
loading: 'py-6 text-center'
},
Expand All @@ -27,7 +28,7 @@ export default (options: Required<ModuleOptions>) => ({
},
loading: {
true: {
thead: 'after:absolute after:bottom-0 after:inset-x-0 after:h-px'
thead: 'after:absolute after:z-[1] after:h-px'
}
},
loadingAnimation: {
Expand Down
Loading