fix(FileUpload): improve file removal a11y #4607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should lead to better a11y as the user's focus will remain in the context of the FileUpload component.
J-Michalek
changed the title
commit: |
benjamincanac
approved these changes
Jul 27, 2025
|
Thanks @J-Michalek! 😊 |
|
There is one more improvement which is opening the file dialog when pressing enter/space while the dropzone is focused, I will create a new PR for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves: #4590
❓ Type of change
📚 Description
I have added the
aria-labelattribute to the remove file button and added focus to the drop zone element after a file is removed - both changes should lead to better a11y.📝 Checklist