Fix zsh alias #733
Merged
Fix zsh alias #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterNayru
force-pushed
the
fix-zsh-alias
branch
4 times, most recently
from
8f8aed4 to
082f2f1
Compare
MasterNayru
force-pushed
the
fix-zsh-alias
branch
from
082f2f1 to
0843f06
Compare
|
Thanks! |
riley-martine
pushed a commit
to riley-martine/thefuck
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would appear that the alias printed out in v3.24 has a variable scoping issue with the TF_HISTORY variable. The bash alias exports TF_HISTORY and does an unset on it afterwards, which seems to make it work fine. With the zsh alias in its current form, os.environ never sees the TF_HISTORY variable, and since $TF_PREVIOUS is no longer being fed into thefuck it just prints out the usage message. I have tested this change locally and it seems to make it work again.
This should resolve issue #725