buildtin: Add first version of bind #349
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a simple, introductory version of the buildtin `bind` command that just passes configuration options to `readline`. * Fixes oils-for-unix#339. Signed-off-by: mr.Shu <[email protected]>
Open
andychu
reviewed
Jun 20, 2019
| raise args.UsageError('bind keyseq:function-name') | ||
|
|
||
| status = 0 | ||
| for i in xrange(1, len(arg_vec.strs)): |
There was a problem hiding this comment.
Does bash process all positional arguments?
When I do help bind, it doesn't have the customary ... syntax for the last arg:
[keyseq:readline-function or readline-command]
I've never used bind honestly. Can you maybe write some manual test cases in the comments?
Ideally tests should be automatic, but interactive readline stuff is hard to test of course... I maintain some manual test cases here, and those would be useful for bind
https://github.com/oilshell/oil/wiki/Testing-the-Interactive-Shell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple, introductory version of the buildtin
bindcommand thatjust passes configuration options to
readline.Fixes Implement
bindbuiltin #339.Signed-off-by: mr.Shu [email protected]