TraceIdRatioBased deprecation plan, "ProbabilitySampler" #4627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…phase-in new behavior
jmacd
commented
Aug 14, 2025
jmacd
commented
Aug 14, 2025
jmacd
commented
Aug 14, 2025
5 tasks
trask
reviewed
Aug 19, 2025
oertl
reviewed
Aug 25, 2025
Co-authored-by: Otmar Ertl <[email protected]>
Co-authored-by: Otmar Ertl <[email protected]>
…ication into jmacd/otep235migrate
…-specification into jmacd/otep235migrate
…ication into jmacd/otep235migrate
|
I eliminated any specification about the description. I agree with this approach @trask, especially considering the primary concern of this effort is to label every sampled span with a probability! |
trask
reviewed
Aug 28, 2025
trask
reviewed
Aug 28, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
carlosalberto
approved these changes
Sep 12, 2025
|
A few details to resolve but overall LGTM. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Co-authored-by: Trask Stalnaker <[email protected]>
…ication into jmacd/otep235migrate
trask
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1413
Fixes #4601
Changes
Restores TraceIdRatioBased specification from before #4166.
CHANGELOG.mdfile updated for non-trivial changes