refactor: Replace connect with useSelector() and useDispatch() 5/5 #2318 #2423

ahtesham-quraish · 2025-09-04T09:34:53Z

Description

Replace connect with useSelector() and useDispatch() 5/5 #2318

Supporting information

Link to other information about the change, such as GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for manually testing this change.

Other information

Include anything else that will help reviewers and consumers understand the change.

Does this change depend on other changes elsewhere?
Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

Any new files are using TypeScript (.ts, .tsx).
Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
All new i18n messages in messages.ts files have a description for translators to use.
Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

openedx-webhooks · 2025-09-04T09:34:58Z

Thanks for the pull request, @ahtesham-quraish!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2025-09-04T10:01:57Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.74%. Comparing base (2fb04d6) to head (61fd599).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2423      +/-   ##
==========================================
+ Coverage   94.63%   94.74%   +0.11%     
==========================================
  Files        1180     1192      +12     
  Lines       26151    27049     +898     
  Branches     5818     6039     +221     
==========================================
+ Hits        24747    25628     +881     
- Misses       1333     1347      +14     
- Partials       71       74       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…enedx#2318

brian-smith-tcril · 2025-09-11T13:49:02Z

I'm going to try closing and re-opening this PR to see if it resolves the CLA check issue

bradenmacdonald

Thanks @ahtesham-quraish.

bradenmacdonald · 2025-09-11T22:15:56Z

...deoEditor/components/VideoSettingsModal/components/TranscriptWidget/ImportTranscriptCard.jsx

-
-export const mapDispatchToProps = {
-  importTranscript: thunkActions.video.importTranscript,
+  setOpen: PropTypes.func.isRequired,
 };

 export const ImportTranscriptCardInternal = ImportTranscriptCard; // For testing only


Suggested change

export const ImportTranscriptCardInternal = ImportTranscriptCard; // For testing only

Please get rid of this Internal alias - it's not needed anymore :)

bradenmacdonald · 2025-09-11T22:17:05Z

...deoEditor/components/VideoSettingsModal/components/TranscriptWidget/ImportTranscriptCard.jsx

-);
-
-ImportTranscriptCard.defaultProps = {
-  setOpen: true,


This default was just totally wrong, right? setOpen is supposed to be a function.

bradenmacdonald · 2025-09-11T22:17:54Z

...itor/components/VideoSettingsModal/components/TranscriptWidget/ImportTranscriptCard.test.tsx

@@ -2,27 +2,22 @@ import React from 'react';
 import {
  render, screen, fireEvent, initializeMocks,
 } from '@src/testUtils';
+import * as ReactRedux from 'react-redux';
 import { ImportTranscriptCardInternal as ImportTranscriptCard } from './ImportTranscriptCard';


Suggested change

import { ImportTranscriptCardInternal as ImportTranscriptCard } from './ImportTranscriptCard';

import { ImportTranscriptCard } from './ImportTranscriptCard';

bradenmacdonald · 2025-09-11T22:20:18Z

...s/VideoEditor/components/VideoSettingsModal/components/TranscriptWidget/LanguageSelector.jsx


-const LanguageSelector = ({
-  index, // For a unique id for the form control


Nit: Can you please leave in this comment "For a unique id for the form control" explaining what index is ? Ideally use JSDoc syntax so it will show up on hover in people's IDEs.

bradenmacdonald · 2025-09-11T22:21:26Z

...s/VideoEditor/components/VideoSettingsModal/components/TranscriptWidget/LanguageSelector.jsx

@@ -95,12 +103,25 @@ const LanguageSelector = ({
        <Dropdown.Menu>
          {Object.entries(videoTranscriptLanguages).map(([lang, text]) => {
            if (language === lang) {
-              return (<Dropdown.Item>{text}<Icon className="text-primary-500" src={Check} /></Dropdown.Item>);
+              return (
+                <Dropdown.Item key={lang}>


Thanks for catching the missing key here.

bradenmacdonald · 2025-09-11T22:43:00Z

...s/containers/VideoEditor/components/VideoSettingsModal/components/TranscriptWidget/index.jsx

 TranscriptWidget.propTypes = {
-  // redux
-  transcripts: PropTypes.arrayOf(PropTypes.string).isRequired,
+  transcripts: PropTypes.arrayOf(PropTypes.string),
  selectedVideoTranscriptUrls: PropTypes.shape(),
-  allowTranscriptDownloads: PropTypes.bool.isRequired,
-  showTranscriptByDefault: PropTypes.bool.isRequired,
-  allowTranscriptImport: PropTypes.bool.isRequired,
-  updateField: PropTypes.func.isRequired,
-  isUploadError: PropTypes.bool.isRequired,
-  isDeleteError: PropTypes.bool.isRequired,
+  allowTranscriptDownloads: PropTypes.bool,
+  showTranscriptByDefault: PropTypes.bool,
+  allowTranscriptImport: PropTypes.bool,
+  updateField: PropTypes.func,
+  isUploadError: PropTypes.bool,
+  isDeleteError: PropTypes.bool,
 };


Please delete this whole thing - TranscriptWidget no longer accepts any props.

bradenmacdonald · 2025-09-11T22:43:15Z

...s/containers/VideoEditor/components/VideoSettingsModal/components/TranscriptWidget/index.jsx

 TranscriptWidget.defaultProps = {
  selectedVideoTranscriptUrls: {},
 };


Suggested change

TranscriptWidget.defaultProps = {

selectedVideoTranscriptUrls: {},

};

bradenmacdonald · 2025-09-11T22:43:28Z

...s/containers/VideoEditor/components/VideoSettingsModal/components/TranscriptWidget/index.jsx

+export const TranscriptWidgetInternal = TranscriptWidget;
+export default TranscriptWidget;


Suggested change

export const TranscriptWidgetInternal = TranscriptWidget;

export default TranscriptWidget;

export { TranscriptWidget };

bradenmacdonald · 2025-09-11T22:45:29Z

...containers/VideoEditor/components/VideoSettingsModal/components/VideoPreviewWidget/index.jsx

-import PropTypes from 'prop-types';
-import React from 'react';
-import { connect } from 'react-redux';
+import { useSelector } from 'react-redux';// ✅ adjust import path depending on your setup


Suggested change

import { useSelector } from 'react-redux';// ✅ adjust import path depending on your setup

import { useSelector } from 'react-redux';

??

bradenmacdonald · 2025-09-11T22:46:07Z

...iners/VideoEditor/components/VideoSettingsModal/components/VideoPreviewWidget/index.test.tsx

@@ -0,0 +1,64 @@
+import { editorRender, type PartialEditorState } from '@src/editors/editorTestRender';
+import { screen } from '@testing-library/react';
+import { initializeMocks } from '../../../../../../../testUtils';


Suggested change

import { initializeMocks } from '../../../../../../../testUtils';

import { initializeMocks } from '@src/testUtils';

bradenmacdonald · 2025-09-11T22:48:26Z

@ahtesham-quraish Can you please also update the PR "Testing instructions" with instructions for how to test this manually? I want to make sure the editor components are still working after the refactor.

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 4, 2025

openedx-webhooks added this to Contributions Sep 4, 2025

github-project-automation bot moved this to Needs Triage in Contributions Sep 4, 2025

ahtesham-quraish force-pushed the ahtesham/#2318 branch 2 times, most recently from 1edb908 to eb34199 Compare September 4, 2025 09:51

refactor: Replace connect with useSelector() and useDispatch() 5/5 op…

61fd599

…enedx#2318

ahtesham-quraish force-pushed the ahtesham/#2318 branch from eb34199 to 61fd599 Compare September 4, 2025 10:26

mphilbrick211 moved this from Needs Triage to Needs Tests Run or CLA Signed in Contributions Sep 10, 2025

brian-smith-tcril closed this Sep 11, 2025

github-project-automation bot moved this from Needs Tests Run or CLA Signed to Done in Contributions Sep 11, 2025

brian-smith-tcril reopened this Sep 11, 2025

bradenmacdonald reviewed Sep 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: Replace connect with useSelector() and useDispatch() 5/5 #2318 #2423

refactor: Replace connect with useSelector() and useDispatch() 5/5 #2318 #2423

Uh oh!

ahtesham-quraish commented Sep 4, 2025

Uh oh!

openedx-webhooks commented Sep 4, 2025

Uh oh!

codecov bot commented Sep 4, 2025 •

edited

Loading

Uh oh!

brian-smith-tcril commented Sep 11, 2025

Uh oh!

bradenmacdonald left a comment

Uh oh!

bradenmacdonald Sep 11, 2025

Uh oh!

bradenmacdonald Sep 11, 2025

Uh oh!

bradenmacdonald Sep 11, 2025

Uh oh!

bradenmacdonald Sep 11, 2025

Uh oh!

bradenmacdonald Sep 11, 2025

Uh oh!

bradenmacdonald Sep 11, 2025

Uh oh!

bradenmacdonald Sep 11, 2025

Uh oh!

bradenmacdonald Sep 11, 2025

Uh oh!

bradenmacdonald Sep 11, 2025

Uh oh!

bradenmacdonald Sep 11, 2025

Uh oh!

bradenmacdonald commented Sep 11, 2025

Uh oh!

Uh oh!

	import { ImportTranscriptCardInternal as ImportTranscriptCard } from './ImportTranscriptCard';
	import { ImportTranscriptCard } from './ImportTranscriptCard';


		const LanguageSelector = ({
		index, // For a unique id for the form control

	TranscriptWidget.defaultProps = {
	selectedVideoTranscriptUrls: {},
	};

		export const TranscriptWidgetInternal = TranscriptWidget;
		export default TranscriptWidget;

	export const TranscriptWidgetInternal = TranscriptWidget;
	export default TranscriptWidget;
	export { TranscriptWidget };

	import { useSelector } from 'react-redux';// ✅ adjust import path depending on your setup
	import { useSelector } from 'react-redux';

	import { initializeMocks } from '../../../../../../../testUtils';
	import { initializeMocks } from '@src/testUtils';

refactor: Replace connect with useSelector() and useDispatch() 5/5 #2318 #2423

Are you sure you want to change the base?

refactor: Replace connect with useSelector() and useDispatch() 5/5 #2318 #2423

Uh oh!

Conversation

ahtesham-quraish commented Sep 4, 2025

Description

Supporting information

Testing instructions

Other information

Best Practices Checklist

Uh oh!

openedx-webhooks commented Sep 4, 2025

Uh oh!

codecov bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

brian-smith-tcril commented Sep 11, 2025

Uh oh!

bradenmacdonald left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bradenmacdonald commented Sep 11, 2025

Uh oh!

Uh oh!

codecov bot commented Sep 4, 2025 •

edited

Loading