Skip to content

Conversation

HimaBinduMeda
Copy link
Contributor

@HimaBinduMeda HimaBinduMeda commented Sep 8, 2025

Updated libxml2 to v2.14.5.
Verified build on all platforms. No issues seen


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1886/head:pull/1886
$ git checkout pull/1886

Update a local copy of the PR:
$ git checkout pull/1886
$ git pull https://git.openjdk.org/jfx.git pull/1886/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1886

View PR using the GUI difftool:
$ git pr show -t 1886

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1886.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 8, 2025

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 8, 2025

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361893: Update libxml2 to 2.14.5

Reviewed-by: kcr, sykora

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Ready for review label Sep 8, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 8, 2025

Webrevs

@kevinrushforth kevinrushforth self-requested a review September 8, 2025 21:08
@kevinrushforth
Copy link
Member

Reviewers: @kevinrushforth @tiainen

/reviewers 2

@openjdk
Copy link

openjdk bot commented Sep 8, 2025

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing looks good. Code changes look good and match the upstream, although I noticed that there are two files that we have in our repo that are not in the upstream repo:

  • src/nanoftp.c -- removed as part of this update (i.e., removed between v2.13.8 and v2.14.5)
  • src/buf.h -- removed a couple updates ago (it moved to include/private/buf.h between v2.10.4 and v2.12.6 so now we have two copies)

I recommend either removing them or filing a follow-up cleanup bug to do so.

I'll approve it as-is. If you decide to make changes I'll reapprove.

Copy link
Collaborator

@tiainen tiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and tests ran fine.

@openjdk openjdk bot added the ready Ready to be integrated label Sep 15, 2025
@HimaBinduMeda
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 15, 2025

Going to push as commit 15c50c2.
Since your change was applied there have been 11 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 15, 2025
@openjdk openjdk bot closed this Sep 15, 2025
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Sep 15, 2025
@openjdk
Copy link

openjdk bot commented Sep 15, 2025

@HimaBinduMeda Pushed as commit 15c50c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants