Skip to content

Conversation

andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented Sep 8, 2025

Further additions to the MonkeyTester application:

  • readme.md: In this command we should not add javafx-sdk-24 in the path. JAVAFX already includes sdk folder we just need to use java -p <JAVAFX>/lib/ --add-modules ALL-MODULE-PATH -jar MonkeyTester.jar
  • TableView page: canvas based cell and row factories
  • Dialog page
  • Progress Bar Page
  • additional scripts in the WritingSystemsDemo
  • pure Swing JTextField/JTextArea window
  • ImageView page
  • AudioClip page
  • events in Drag and Drop page
  • added miscellaneous options
  • TextFlow page: updated hit info visualization, tab stop policy
  • WebView page: added direct html input

Also, upgraded the build scripts and eclipse settings to JDK24 and JFX24 (you may need to upgrade Eclipse).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Patch contains a binary file (tests/manual/monkey/src/com/oracle/tools/fx/monkey/media/yo.mp3)

Issue

  • JDK-8353743: [TestBug] Monkey Tester Application Update 6 (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1887/head:pull/1887
$ git checkout pull/1887

Update a local copy of the PR:
$ git checkout pull/1887
$ git pull https://git.openjdk.org/jfx.git pull/1887/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1887

View PR using the GUI difftool:
$ git pr show -t 1887

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1887.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 8, 2025

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 8, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@andy-goryachev-oracle andy-goryachev-oracle marked this pull request as ready for review September 8, 2025 23:09
@openjdk openjdk bot added the rfr Ready for review label Sep 8, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 8, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Ready for review
Development

Successfully merging this pull request may close these issues.

1 participant