Skip to content

Conversation

subnetmarco
Copy link

Closes #7.

@subnetmarco
Copy link
Author

@agentzh any comments on this PR?

@agentzh
Copy link
Member

agentzh commented Oct 16, 2016

I think it's a bit confusing to use the two words "timeout" and "exptime" in the same API since they are essentially the same thing in this context. I think you are actually proposing a per-key timeout value here, right? Then we can just accept a "timeout" argument in lock() to simply override the object-level default timeout setting. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants