Skip to content

Conversation

popovaan
Copy link
Contributor

@popovaan popovaan commented Jun 6, 2025

No description provided.

@github-actions github-actions bot added the category: WWB PR changes WWB label Jun 6, 2025
@Wovchena Wovchena requested review from sbalandi and Copilot June 19, 2025 07:37
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the OpenVINO GenAI visual-text pipeline by allowing a continuous-batching configuration (cb_config) to be passed and applied via the new scheduler API. Function signatures for load_visual_text_genai_pipeline, load_visual_text_model, and the top-level load_model dispatcher were extended to accept and forward arbitrary kwargs.

  • Add cb_config handling and create SchedulerConfig when provided
  • Update pipeline instantiation to use scheduler_config and set ATTENTION_BACKEND
  • Propagate **kwargs through load_visual_text_model and load_model
Comments suppressed due to low confidence (3)

tools/who_what_benchmark/whowhatbench/model_loaders.py:219

  • This function now accepts cb_config within kwargs, but there’s no docstring describing it. Please add or update the docstring to explain the cb_config parameter, its expected structure, and how it controls continuous batching.
def load_visual_text_genai_pipeline(model_dir, device="CPU", ov_config=None, **kwargs):

tools/who_what_benchmark/whowhatbench/model_loaders.py:226

  • [nitpick] The key cb_config is a bit ambiguous—consider renaming it to scheduler_config or batching_config for clarity and consistency with get_scheduler_config_genai.
    is_continuous_batching = kwargs.get("cb_config", None) is not None

tools/who_what_benchmark/whowhatbench/model_loaders.py:226

  • The new continuous-batching code path isn’t covered by existing tests. Please add unit tests for when cb_config is provided and verify that scheduler_config is applied correctly.
    is_continuous_batching = kwargs.get("cb_config", None) is not None

try:
import openvino_genai
except ImportError as e:
logger.error("Failed to import openvino_genai package. Please install it. Details:\n", e)
Copy link
Preview

Copilot AI Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing the exception as a separate argument may not include stack trace in all logging setups. Consider using logger.exception(...) or logger.error(..., exc_info=True) to ensure the error details are captured.

Suggested change
logger.error("Failed to import openvino_genai package. Please install it. Details:\n", e)
logger.error("Failed to import openvino_genai package. Please install it. Details:\n", exc_info=True)

Copilot uses AI. Check for mistakes.

@Wovchena Wovchena added this pull request to the merge queue Jun 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 19, 2025
@Wovchena Wovchena added this pull request to the merge queue Jun 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2025
@Wovchena Wovchena added this pull request to the merge queue Jun 20, 2025
Merged via the queue into openvinotoolkit:master with commit 7d14750 Jun 20, 2025
89 of 91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: WWB PR changes WWB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants