Disabled crop of the prompt for minicpmv. #2320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors how model types with automatic cropping are detected and adds support for the minicpmv model to disable prompt cropping.
- Introduces
is_model_with_automatic_crophelper to centralize the check for'internvl'and'minicpmv'inmodel_type. - Updates the visual-text evaluator logic to use the new helper.
Comments suppressed due to low confidence (3)
tools/who_what_benchmark/whowhatbench/wwb.py:369
- [nitpick] The function name is a bit verbose and unclear—consider renaming to
supports_automatic_croporhas_automatic_crop_supportto better express that it returns a boolean predicate.
def is_model_with_automatic_crop(config):
tools/who_what_benchmark/whowhatbench/wwb.py:369
- Add a short docstring explaining what constitutes a model with automatic cropping and when this helper should be used.
def is_model_with_automatic_crop(config):
tools/who_what_benchmark/whowhatbench/wwb.py:369
- Introduce unit tests for
is_model_with_automatic_cropto verify both positive and negative matches forinternvl,minicpmv, and other model types.
def is_model_with_automatic_crop(config):
|
|
||
|
|
||
| def is_model_with_automatic_crop(config): | ||
| return "internvl" in config.model_type or "minicpmv" in config.model_type |
There was a problem hiding this comment.
Perform a case-insensitive check by using config.model_type.lower() to avoid missing matches if the casing changes.
Suggested change
| return "internvl" in config.model_type or "minicpmv" in config.model_type | |
| model_type_lower = config.model_type.lower() | |
| return "internvl" in model_type_lower or "minicpmv" in model_type_lower |
Copilot uses AI. Check for mistakes.
Wovchena
reviewed
Jun 9, 2025
Wovchena
approved these changes
Jun 10, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled crop of the prompt for minicpmv.