[TTS] Correct perf metrics for second or so generation #2463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kazantsev, Roman <[email protected]>
Wovchena
approved these changes
Jul 21, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes performance metrics accumulation in the SpeechT5 TTS model by ensuring metrics are properly reset for each generation call instead of accumulating across multiple generations.
- Changes performance metrics to be stored in the local result object instead of the class member
- Ensures metrics are reset for each generation call by using fresh result object metrics
- Updates the class member metrics only at the end with the current generation's metrics
| m_perf_metrics.evaluate_statistics(); | ||
| gen_speech_res.perf_metrics = m_perf_metrics; | ||
| gen_speech_res.perf_metrics.evaluate_statistics(); | ||
| m_perf_metrics = gen_speech_res.perf_metrics; |
There was a problem hiding this comment.
[nitpick] Consider whether updating the class member m_perf_metrics is necessary. If this is only used for external access to the last generation's metrics, consider documenting this behavior or removing the assignment if the metrics are only needed in the return value.
Copilot uses AI. Check for mistakes.
sbalandi
approved these changes
Jul 21, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details: For second generation or so, we need to reset performance metrics. Now it is accumulating that is not correct.
Ticket: 170874