Skip to content

Conversation

tiger100256-hu
Copy link
Contributor

@tiger100256-hu tiger100256-hu commented Sep 3, 2025

Details:

  • fuzzy test should not be in pre-commit test, so move it into weekly test
  • create event_name as job cxx unit test input

Tickets:

@github-actions github-actions bot added category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code labels Sep 3, 2025
@@ -0,0 +1,202 @@
name: fuzzy (Ubuntu 22.04, Python 3.11)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to create a separate workflow. It would be better to create a new job in the already existing workflow: ubuntu_22.yml, similar to

There would be no need to build OV from scratch.

It will need the following trigger:

if: ${{ github.event_name == 'schedule' }}

The Ubuntu 22.04 workflow already runs on a schedule basis, every Wednesday and Saturday, so the only thing needed is to transfer the Fuzzy_Tests job from this file into ubuntu_22.yml and delete this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already remove the fuzzy.yml and add paddle fuzzy test in test job C++ unit test with condition event schedule, ubuntu_22.yml will trigger C++ unit test. so I think ubuntu_22.yml should trigger the paddle fuzzy test

@akashchi akashchi self-assigned this Sep 3, 2025
${{ env.INSTALL_TEST_DIR }}/paddle_tests --gtest_filter="-PaddleFuzzyOpTest*" --gtest_print_time=1 --gtest_output=xml:${{ env.INSTALL_TEST_DIR }}/TEST-PaddleTests.xml
- name: PaddlePaddle frontend Fuzzy Op tests
if: ${{ github.event_name == 'schedule' && fromJSON(inputs.affected-components).PDPD_FE.test && runner.os != 'Windows' }} # Ticket: 149651
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if: ${{ github.event_name == 'schedule' && fromJSON(inputs.affected-components).PDPD_FE.test && runner.os != 'Windows' }} # Ticket: 149651
if: ${{ inputs.event == 'schedule' && runner.os != 'Windows' }} # Ticket: 149651

.github/workflows/job_cxx_unit_tests.yml is a reusable workflow and does not have the github context. You should pass the event_name into the inputs from the parent workflow and use it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, I use input.event_name and add event_name as input in ubunut_22.yml, please help to check if it is ok, thanks

@tiger100256-hu tiger100256-hu marked this pull request as ready for review September 8, 2025 02:03
@tiger100256-hu tiger100256-hu requested a review from a team as a code owner September 8, 2025 02:03
@@ -308,6 +308,7 @@ jobs:
image: ${{ fromJSON(needs.docker.outputs.images).ov_test.ubuntu_22_04_x64 }}
affected-components: ${{ needs.smart_ci.outputs.affected_components }}
os: 'ubuntu_22_04'
event_name: ${{ github.event_name }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

${{ env.INSTALL_TEST_DIR }}/paddle_tests --gtest_print_time=1 --gtest_output=xml:${{ env.INSTALL_TEST_DIR }}/TEST-PaddleTests.xml
${{ env.INSTALL_TEST_DIR }}/paddle_tests --gtest_filter="-PaddleFuzzyOpTest*" --gtest_print_time=1 --gtest_output=xml:${{ env.INSTALL_TEST_DIR }}/TEST-PaddleTests.xml

- name: PaddlePaddle frontend Fuzzy Op tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The - name is misaligned:

Suggested change
- name: PaddlePaddle frontend Fuzzy Op tests
- name: PaddlePaddle frontend Fuzzy Op tests

Signed-off-by: HU Yuan2 <[email protected]>
@akashchi akashchi self-requested a review September 10, 2025 11:20
@akashchi akashchi added this pull request to the merge queue Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants