Improved pull request "Files Changed" experience feedback #163932
Replies: 1334 comments 452 replies
-
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state
Example of desired state
This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
The tab for |
Beta Was this translation helpful? Give feedback.
-
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
On the Files changed tab I can only see 19 files out of 66. Why? |
Beta Was this translation helpful? Give feedback.
-
I used to be able to click on a useful link to see the submodule diff in PRs but now its just plain text. Could we have that back pls? |
Beta Was this translation helpful? Give feedback.
-
It doesn't always seem to remember if hide whitespace was turned on. |
Beta Was this translation helpful? Give feedback.
-
can we finally have a view of file state on the moment of comment, and current state to figure out how or comment was resolved? |
Beta Was this translation helpful? Give feedback.
-
When a file (symlink) is deleted and then a real file added again with the same name, only the deletion is displayed. |
Beta Was this translation helpful? Give feedback.
-
I haven't found any feedback about it: I'm missing some very convenient keyboard shortcuts, namely T to focus the file filter input and CmdG to add a suggestion into a comment box. |
Beta Was this translation helpful? Give feedback.
-
Bug: when using "Changes since your last review", if I expand the diff file (either "expand all lines" button at the top of the file or partial-expand on clicking on the folded area), the expanded version seems to show changes from "All commits" just for that file. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Sorry if this has been reported already, I'm not patient enough to open 1000s of commands and then Ctrl-F through them. When adding a suggestion equal to the original text, the following error is shown:
Problem is, it also prevents any further interaction with the text box, disabling the text area and both "cancel" and "submit" buttons. This seems like a bug because the "submit" button displays a loading indicator that never ends. |
Beta Was this translation helpful? Give feedback.
-
I really like how the new UI surfaces draft reviews and speeds up navigation—feels a lot smoother. What still feels clunky is jumping between multiple comment threads on the same file. Something like a sidebar “comment navigator” (next/previous thread, unresolved only, etc.) would help keep context without scrolling endlessly. Almost like having a table of contents, but just for feedback. |
Beta Was this translation helpful? Give feedback.
-
I find myself going back to read the PR description at times. Like past UI, I have to scroll to the top of the screen (which for a longer PR is awkward) to get to the "Discussion" tab. Not terrible but also seems fixable. |
Beta Was this translation helpful? Give feedback.
-
line spacing being bigger means fewer lines of code render per unit of space. ouch. why? |
Beta Was this translation helpful? Give feedback.
-
I don't seem to see the CODEOWNERS file validation like I can in the old experience. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
During a review, I'd like to be able to add comments in any line of the file even if not changed. |
Beta Was this translation helpful? Give feedback.
-
When a comment is in a file whose diff is not displayed because it is too large, "jump to comment in the diff" from Comments does nothing. It probably has no anchor to redirect to, or the anchor is not there because the diff has not been rendered. It would be very nice if, maybe after asking for confirmation, the diff would be rendered (just as if the user clicked on "Show diff") before jumping to the comment. |
Beta Was this translation helpful? Give feedback.
-
Will "Changed since last view" badges still appear on the headers of files that have changed since being marked as viewed? I find the badges helpful for reviewing large pull requests, and think I've observed them being only intermittently available during the new experience rollout. |
Beta Was this translation helpful? Give feedback.
-
I don't see anyone mentioning mobile. It does not work, generally. It is zoomed all the way out |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
About the new experience
This refresh focuses on performance, accessibility, and clarity so reviews stay responsive—even on the largest pull requests.
What’s new ?
Performance 🚀
UX ✨
Accessibility
What's missing? 🟨
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
Beta Was this translation helpful? Give feedback.
All reactions