Skip to content

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Dec 29, 2022

Ref #646

@rkrasiuk rkrasiuk requested a review from gakonst as a code owner December 29, 2022 09:36
@rkrasiuk rkrasiuk marked this pull request as draft December 29, 2022 09:36
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Merging #640 (74367c8) into main (47d0449) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #640      +/-   ##
==========================================
+ Coverage   72.14%   72.21%   +0.06%     
==========================================
  Files         258      258              
  Lines       25961    26026      +65     
==========================================
+ Hits        18730    18795      +65     
  Misses       7231     7231              
Flag Coverage Δ
unit-tests 72.21% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bin/reth/src/main.rs 14.28% <0.00%> (-2.39%) ⬇️
crates/net/nat/src/lib.rs 60.74% <0.00%> (-1.16%) ⬇️
crates/net/discv4/src/lib.rs 51.37% <0.00%> (+0.04%) ⬆️
crates/stages/src/stages/headers.rs 97.24% <0.00%> (+0.04%) ⬆️
crates/net/discv4/src/mock.rs 88.78% <0.00%> (+0.05%) ⬆️
crates/stages/src/stages/execution.rs 89.41% <0.00%> (+0.05%) ⬆️
crates/net/eth-wire/src/p2pstream.rs 77.70% <0.00%> (+0.09%) ⬆️
crates/stages/src/stages/bodies.rs 91.68% <0.00%> (+0.09%) ⬆️
crates/net/network/src/fetch/mod.rs 83.03% <0.00%> (+0.10%) ⬆️
crates/stages/src/pipeline.rs 86.86% <0.00%> (+0.13%) ⬆️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rkrasiuk rkrasiuk requested a review from mattsse December 29, 2022 11:31
@rkrasiuk rkrasiuk marked this pull request as ready for review December 29, 2022 11:31
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gakonst gakonst merged commit 208118c into main Dec 29, 2022
@gakonst gakonst deleted the rkrasiuk/stable-toolchain branch December 29, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants