Skip to content

Conversation

mikuso
Copy link
Contributor

@mikuso mikuso commented Feb 20, 2025

This PR adds/fixes JSDocs throughout the project by:

  • Using @import to add missing type references into the appropriate files.
  • Adding necessary types which were missing from the original conversion the box2d source.
  • Fixing JSDoc issues with some types & parameter names that were slightly wrong.

In addition to this, there were a couple of other corrections I made to minor issues I discovered during this process:

  1. In mouse_joint_c.js, motor_joint_c.js and revolute_joint_c.js, plain objects were used in lieu of an instance of b2Mat22 for various values of K. For consistency with the original source, the JSDocs, and other similar functions, I have corrected these to use b2Mat22 as originally intended.
  2. A couple of assertions in solver_set_c.js have had their expressions typecast to booleans to be more explicit about what was actually being asserted (but mainly just to satisfy the typescript compiler).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant