Fix imageCollections default Tileset values #7053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Snoturky. Thanks for submitting this PR. We have merged this and pushed it to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes below:
A recent change (a763d77) prevents the default values for Tileset's tileProperties and tileData from being set because it passes
nullinstead ofundefinedfor those constructor args.This restores those default values, eliminating an
Uncaught TypeError: Cannot read properties of nullerror here when using ImageCollections.I rolled back my phaser version from 3.88 to 3.87 (before the above changes) and the error was gone.