Skip to content

Fix: prevent gamepad buttons from sending bogus down events on init #7126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: prevent gamepad buttons from sending bogus down events on init #7126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/input/gamepad/Button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,13 @@ var Events = require('./events');
*
* @param {Phaser.Input.Gamepad.Gamepad} pad - A reference to the Gamepad that this Button belongs to.
* @param {number} index - The index of this Button.
* @param {boolean} isPressed - Whether or not the button is already being pressed at creation time. This prevents the Button from emitting spurious 'down' events at first update.
*/
var Button = new Class({

initialize:

function Button (pad, index)
function Button (pad, index, isPressed)
{
/**
* A reference to the Gamepad that this Button belongs to.
Expand Down Expand Up @@ -82,7 +83,7 @@ var Button = new Class({
* @default false
* @since 3.0.0
*/
this.pressed = false;
this.pressed = isPressed;
},

/**
Expand Down
2 changes: 1 addition & 1 deletion src/input/gamepad/Gamepad.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ var Gamepad = new Class({

for (var i = 0; i < pad.buttons.length; i++)
{
buttons.push(new Button(this, i));
buttons.push(new Button(this, i, (pad.buttons[i].value >= 0.5)));
}

/**
Expand Down