Move proto codec to separate Go module #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc @glimchb , is this okay for you? |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #138 +/- ##
=======================================
Coverage 65.26% 65.26%
=======================================
Files 25 25
Lines 2096 2096
=======================================
Hits 1368 1368
Misses 601 601
Partials 127 127 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
sure. maybe just add quick example of new usage... |
Good idea 👍 . I just created one and it works fine, but I'll submit that in a separate PR. |
To not force the proto transitive dependency on users who import the encoding package while only using stdlib codecs.
Like encoding.JSON and encoding.Gob, but here just Codec because we're in the proto package and want to avoid stuttering.
philippgille
force-pushed
the
move-proto-codec-to-separate-go-module
branch
from
966fc3a to
2a8d6e7
Compare
|
PR for the code example: #144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning: To not force the proto transitive dependency on users who import the encoding package while only using stdlib codecs, as mentioned here.