Skip to content

reduce eagerness of RefreshUtils to reduce circular dependency errors #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

reduce eagerness of RefreshUtils to reduce circular dependency errors #627

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bab43b
remove eagerness of RefreshUtils to reduce circular dependency errors
Apr 20, 2022
829e1ad
do not skip default exports
Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions lib/runtime/RefreshUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ function getReactRefreshBoundarySignature(moduleExports) {
continue;
}

if (key !== 'default' && key[0] != key[0].toUpperCase()) {
continue;
}

signature.push(key);
signature.push(Refresh.getFamilyByType(moduleExports[key]));
}
Expand Down Expand Up @@ -117,6 +121,11 @@ function isReactRefreshBoundary(moduleExports) {
continue;
}

if (key !== 'default' && key[0] != key[0].toUpperCase()) {
areAllExportsComponents = false;
continue;
}

// We can (and have to) safely execute getters here,
// as Webpack manually assigns harmony exports to getters,
// without any side-effects attached.
Expand Down Expand Up @@ -155,6 +164,10 @@ function registerExportsForReactRefresh(moduleExports, moduleId) {
continue;
}

if (key !== 'default' && key[0] != key[0].toUpperCase()) {
continue;
}

var exportValue = moduleExports[key];
if (Refresh.isLikelyComponentType(exportValue)) {
var typeID = moduleId + ' %exports% ' + key;
Expand Down