Skip to content

Conversation

andrewtran3643
Copy link

The inactive tab color was hard-coded to #9B8E8A. When using a dark active hint color, the inactive tab appears lighter than the active tab, which can make it seem like the inactive tab is selected.

This PR updates the inactive tab color to use the active hint color, darkened by 20%, and slightly adjusts the text color to be darker for inactive tabs.

This is my first PR—thank you for your patience, and I appreciate any feedback!

image

andrewtran3643 and others added 3 commits August 21, 2025 14:24
for light active hint colors, edited the text color of inactive tabs to blend in indicating inactivity
@andrewtran3643
Copy link
Author

Hi everyone! Just checking in—has there been any interest or feedback on this PR? Are any adjustments needed?

Also, here's what it looks like in another color with transparency:
image

@jacobgkau jacobgkau requested a review from a team August 28, 2025 04:19
@jacobgkau jacobgkau self-assigned this Aug 28, 2025
@jacobgkau
Copy link
Member

@andrewtran3643 Hadn't gotten a chance to look at this yet, sorry (our attention's mostly turned towards COSMIC Epoch, which no longer uses Pop!_Shell). I'll take a look at this on behalf of QA tomorrow. I do think it makes sense to derive the inactive tab color from the active hint color so it matches the active tab color. Shouldn't be any problems as long as it works as expected.

Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:
Screenshot From 2025-08-28 19-26-57
Screenshot From 2025-08-28 19-27-09
Screenshot From 2025-08-28 19-27-29

After:
Screenshot From 2025-08-28 21-42-26
Screenshot From 2025-08-28 21-41-00
Screenshot From 2025-08-28 21-40-32

This is definitely an improvement for non-default active hint colors. However, I'm a little concerned that the difference between active & inactive tabs is less noticeable now.

@andrewtran3643 Would you be able to try and change the shading to match the inactive tab color to what it used to be a little closer when the hint color's set to the default? It doesn't have to be 100% exact, but it seems like e.g. reducing the saturation a bit might get closer to what it used to be. Seems like it could also benefit darker hint colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants