CI: add the PCT enabled, PCT enabled + broken, Custom zeroization (explicit_bzero) #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkannwischer
requested changes
Jul 29, 2025
There was a problem hiding this comment.
Thanks @willieyz. This looks far from ready. Please test your code before opening a PR and requesting a review.
willieyz
force-pushed
the
test-addCITest-PCT-zeroization
branch
2 times, most recently
from
116bcea to
3d46d54
Compare
mkannwischer
force-pushed
the
test-addCITest-PCT-zeroization
branch
from
3d46d54 to
4356926
Compare
willieyz
force-pushed
the
test-addCITest-PCT-zeroization
branch
8 times, most recently
from
136d524 to
031f2f4
Compare
willieyz
force-pushed
the
test-addCITest-PCT-zeroization
branch
from
031f2f4 to
e73121e
Compare
mkannwischer
requested changes
Jul 30, 2025
There was a problem hiding this comment.
Thanks @willieyz! The changes look good.
Can you please split this up into 2 commits. One adding the MLD_MUST_CHECK_RETURN_VALUE and CHECK() parts, and one for adding the actual tests.
Also your commit message needs some work. The first line should not break.
willieyz
force-pushed
the
test-addCITest-PCT-zeroization
branch
from
e73121e to
3372d61
Compare
- Some functions defined in `sign.h` did not properly check or handle their return values. - Introduce the macro: `CHECK` and `MLD_MUST_CHECK_RETURN_VALUE` to enforce correct usage of the return value. Signed-off-by: willieyz <[email protected]>
- `PCT enabled` - `PCT enabled + broken` - `Custom zeroization (explicit_bzero)` Signed-off-by: willieyz <[email protected]>
willieyz
force-pushed
the
test-addCITest-PCT-zeroization
branch
from
3372d61 to
7aa56d4
Compare
mkannwischer
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR related is base on top of Constant-time hardening for
caddq,poly_chknorm,decompose#371, merge this PR after 371 has been mergedResolves CI: Test custom zeroization in CI #383
Resolves Test PCT and PCT breakage in CI #380
This PR add the three tests PCT enabled, PCT enabled + broken, Custom zeroization (explicit_bzero) in the
ci.ymlIt also introduces the MLD_MUST_CHECK_RETURN_VALUE attribute and the CHECK macro to enforce return value checking throughout the codebase.