-
Notifications
You must be signed in to change notification settings - Fork 23
Namespacing: Add MLD_CONFIG_PARAMETER_SET + MLD_CONFIG_NAMESPACE_PREFIX, modify api, common, config accordingly #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jakemas
wants to merge
18
commits into
main
Choose a base branch
from
mldsa-namespacing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… config Signed-off-by: Jake Massimo <[email protected]>
Signed-off-by: Jake Massimo <[email protected]>
Signed-off-by: Jake Massimo <[email protected]>
Signed-off-by: Jake Massimo <[email protected]>
Signed-off-by: Jake Massimo <[email protected]>
Signed-off-by: Jake Massimo <[email protected]>
Signed-off-by: Jake Massimo <[email protected]>
Signed-off-by: Jake Massimo <[email protected]>
444d8dd
to
2f6e248
Compare
Signed-off-by: Jake Massimo <[email protected]>
Signed-off-by: Jake Massimo <[email protected]>
Signed-off-by: Jake Massimo <[email protected]>
1b67935
to
95f0582
Compare
Signed-off-by: Jake Massimo <[email protected]>
Signed-off-by: Jake Massimo <[email protected]>
Signed-off-by: Jake Massimo <[email protected]>
Signed-off-by: Jake Massimo <[email protected]>
Signed-off-by: Jake Massimo <[email protected]>
Signed-off-by: Jake Massimo <[email protected]>
hmm looks like |
Signed-off-by: Jake Massimo <[email protected]>
jakemas
commented
Sep 12, 2025
else | ||
$(error Invalid value of MLDSA_MODE) | ||
endif | ||
|
||
# Add parameter set configuration to build | ||
DEFINES += -DMLD_CONFIG_PARAMETER_SET=$(MLD_CONFIG_PARAMETER_SET) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
theory, cant be defined from here, so its defaulting to 65, and breaking in 87 case (as never set)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WORK in progress. Steps for multi-level build.
testing removing mldsa_mode in another CI
Core System Changes:
MLD_44_ref_
,MLD_65_ref_
,MLD_87_ref_
) with configurableMLD_CONFIG_NAMESPACE_PREFIX
systemtest/mk/compiler.mk
,test/mk/auto.mk
) with compiler feature detection and host capability matchingMLDSA_MODE
(2/3/5) toMLD_CONFIG_PARAMETER_SET
(44/65/87) with backward compatibilityapi.h
tosign.h
, leaving only constants in public APIMLD_NAMESPACE()
for shared functions,MLD_NAMESPACE_K()
for parameter-specific functionsbreak_pct_config.h
,custom_zeroize_config.h
) to use new namespace systemParameter set naming convention
mlkem-native:
MLK_CONFIG_PARAMETER_SET
(512, 768, 1024) →MLKEM_K
(2, 3, 4)mldsa-native:
MLD_CONFIG_PARAMETER_SET
(44, 65, 87) →MLDSA_K
(4, 6, 8) andMLDSA_L
(4, 5, 7)or do we want to preserve the NIST levels in some respect?