Add config param set and namespace prefix #464
Conversation
Signed-off-by: Jake Massimo <[email protected]>
Signed-off-by: Jake Massimo <[email protected]>
Signed-off-by: Jake Massimo <[email protected]>
Signed-off-by: Jake Massimo <[email protected]>
|
The change appears to affect run time of ML-DSA-44 CBMC proof to |
| * | ||
| *****************************************************************************/ | ||
| #ifndef MLD_CONFIG_PARAMETER_SET | ||
| /* Map legacy MLDSA_MODE to new parameter set for backward compatibility */ |
There was a problem hiding this comment.
We can break backwards compatibility here, so let's choose MLD_CONFIG_PARAMETER_SET as the single source of truth and not allow any other configuration.
There was a problem hiding this comment.
Can MLDSA_MODE be removed entirely?
There was a problem hiding this comment.
Agree - MLDSA_MODE should be removed entirely.
@jakemas It's already like this on |
There was a problem hiding this comment.
@jakemas Can you clean up the history and add short yet expressive commit messages?
Also, I don't think we need to worry about backwards compatibility at this point. If you introduce MLD_CONFIG_PARAMETER_SET as the new source of truth for the parameter set, that should supersede all others. Can MLDSA_MODE be removed?
|
Agree with Hanno - one parameter variable should be sufficient. |
|
@hanno-becker Yes of course, I just wanted to get some review before squashing etc. I thought the same thing about removing Ok, I will keep iterating and working on this, just wanted a check in, particularly with strange CI |
Added in minimal framework for multi level build to support new config param mlkem-approach