Port #4888 to v10 #4890
Merged
Port #4888 to v10 #4890
+69
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasylenkoval
commented
Aug 17, 2025
| } | ||
| } | ||
|
|
||
| return oldDom; | ||
| } else if (parentVNode._dom != oldDom) { | ||
| if (oldDom && parentVNode.type && !parentDom.contains(oldDom)) { |
There was a problem hiding this comment.
The ported code diff also happens to contain one more improvement that replaces the parentDom.contains(...) check with !oldDom.parentNode. Original PR: #4666. Please let me know if you don't want to include it here.
There was a problem hiding this comment.
Should be fine I think, test suite passes anyhow. And thanks for tracking down the blame there, saves me from doing it myself
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
rschristian
approved these changes
Aug 17, 2025
|
Thanks @rschristian! Will update the |
Merged
|
Published @vasylenkoval Thank you again for all of this work, you're a hero! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ports commits from #4888 to the v10 branch.