Fix ActionMenu split-button anchor size
#1015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 27b8901 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR expands the clickable area of split-button anchors in ActionMenu to cover the full item by switching the anchor to a grid subgrid and adjusting padding for medium-sized items.
- Changed grid-template-columns to allow the text area to flex.
- Converted the anchor wrapper to use CSS Grid with subgrid sizing.
- Zeroed out parent padding and applied it directly to the anchor for medium items.
- Added a changeset entry summarizing the fix.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/ActionMenu/ActionMenu.module.css | Updated the item’s grid layout, switched the anchor to a full-size subgrid, and added medium padding. |
| .changeset/hungry-tips-sing.md | Added a patch changeset noting the fixed clickable area in split-button mode. |
Comments suppressed due to low confidence (2)
packages/react/src/ActionMenu/ActionMenu.module.css:185
- CSS subgrid is only supported in Firefox. Consider adding a fallback layout or confirming that your supported browser list includes subgrid support to avoid broken layouts.
grid-template-columns: subgrid;
packages/react/src/ActionMenu/ActionMenu.module.css:216
- [nitpick] The CSS :has() selector may not be supported in all target browsers and can have performance implications. Verify browser compatibility or consider an alternative approach for broader support.
.ActionMenu__item--medium:has(.ActionMenu__item-anchor) {
🟢 No design token changes found |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue in
ActionMenuwhere anchor links insplit-buttonmode were only clickable on the text. Now, the clickable area covers the full width and height of the item.Storybook
Screenshots: