-
Notifications
You must be signed in to change notification settings - Fork 53
Update heading sizes in the Prose component #1073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: b89e4d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
This reverts commit cfe8c0b.
meep, sorry y'all. i accidentally hit the wrong button... * * sweats profusely * * |
All good @kellyquesnel, it was ready to merge anyway. Thanks for taking a look and approving it. |
Summary
Towards https://github.com/github/brand-and-marketing-epd/issues/671
Resolves #988
This update makes it easier to distinguish between
h2
andh3
elements in the Prose component, which were previously too similar in size.🔗 Preview link
List of notable changes:
Updated Prose headings
h3
reduced fromsize-500
tosize-400
h4
reduced fromsize-400
tosize-300
h5
reduced fromsubhead-large
tosubhead-medium
h2
andh6
are unchangedAdded a h1 to one of our Prose stories
What should reviewers focus on?
Note: Previous suggestion from Office Hours was to increase the h2 to
28px
on narrow viewports in Prose. This wasn't feasible, as we'd need to override a specific (narrow) breakpoint in in our preset typescale. The number of overrides required for this would risk a wider divergence between our primary type scale and Prose implementation. We also can't increase the h2 overall type scale position as that will increase tablet and desktop sizes too.This PR instead updates Prose headings in the other direction. H1 and H2 remain unchanged, and everything H3+ is now smaller. This should also reduce visual regressions on resource pages, as most pages utilize h1-h4 ranges, rarely using h5 or h6.
Steps to test:
Contributor checklist:
update snapshots
label to the PR)Reviewer checklist:
Screenshots:
Test from a case study page on github.com:
From Storybook: