Set appropriate disabled attribute on Button depending on rendered HTML element

[joshfarrant]

Summary

Updated the Button component to set the appropriate disabled attribute depending on the type of element rendered, e.g.

// All output <button disabled="true">Test</button>
<Button disabled>Test</Button>
<Button aria-disabled="true">Test</Button>

// All output <a aria-disabled="true">Test</a>
<Button as="a" disabled>Test></Button>
<Button as="a" aria-disabled="true">Test</Button>

What should reviewers focus on?

• Check you're happy with the change in general

Steps to test

1. Check that a button exclusively uses the disabled attribute and a link exclusively uses aria-disabled.

Supporting resources (related issues, external links, etc)

• Closes https://github.com/github/primer/issues/3739

Contributor checklist

• All new and existing CI checks pass
• Tests prove that the feature works and covers both happy and unhappy paths
• Any drop in coverage, breaking changes or regressions have been documented above
• UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
• All developer debugging and non-functional logging has been removed
• Related issues have been referenced in the PR description

Reviewer checklist

• Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
• Check that tests prove the feature works and covers both happy and unhappy paths
• Check that there aren't other open Pull Requests for the same update/change

[changeset-bot]

🦋 Changeset detected

Latest commit: 26bad2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@primer/react-brand	Patch
@primer/brand-docs	Patch
@primer/brand-css	Patch
@primer/brand-primitives	Patch
@primer/brand-e2e	Patch
@primer/brand-fonts	Patch
@primer/brand-config	Patch
@primer/brand-storybook	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

🟢 No design token changes found

[github-actions]

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

[Copilot]

Pull Request Overview

This PR updates the Button component to automatically set the appropriate disabled attribute based on the rendered HTML element type. Button elements use the disabled attribute while other elements (like links) use the aria-disabled attribute.

Key changes:

• Modified Button component logic to conditionally set disabled attributes based on element type
• Added comprehensive test coverage for various disabled states and element types
• Added changeset documentation for the breaking change

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
packages/react/src/Button/Button.tsx	Updated component logic to conditionally set disabled/aria-disabled attributes based on element type
packages/react/src/Button/Button.test.tsx	Added comprehensive test cases covering disabled states for button and link elements
.changeset/warm-meals-learn.md	Added changeset documentation for the minor version update

Comments suppressed due to low confidence (1)

packages/react/src/Button/Button.tsx:156

• [nitpick] The variable name disabledProp could be more descriptive. Consider renaming it to disabledAttributes or disabledProps to better reflect that it contains an object with disabled-related attributes.

    let disabledProp

[rezrah]

Pre-emptively approving, but there's some feedback on the changeset I'd love your thoughts on @joshfarrant