-
Notifications
You must be signed in to change notification settings - Fork 53
Update single item PricingOptions layout #1113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update single item PricingOptions layout #1113
Conversation
🦋 Changeset detectedLatest commit: 42fad6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔍 Design token changes foundView CSS variable changes+ --brand-PricingOptions-items1-container-paddingInline: var(--base-size-32); |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the PricingOptions component layout to stack single item content vertically and center-align on large viewports, replacing the previous horizontal two-column layout. The changes simplify the CSS structure and improve the visual presentation for single pricing options.
- Removed complex single-item grid layout with horizontal columns
- Added vertical stacking with 50% width and center alignment for single items
- Updated story example to include feature list for better demonstration
Reviewed Changes
Copilot reviewed 4 out of 16 changed files in this pull request and generated no comments.
File | Description |
---|---|
PricingOptions.module.css | Removes horizontal grid layout for single items, adds vertical centering with 50% width |
PricingOptions.features.stories.tsx | Moves OneOption story and adds FeatureList items for better visual testing |
pricing-options.json | Adds new design token for single item container padding |
bright-gifts-cheer.md | Documents the layout change in changelog |
Comments suppressed due to low confidence (1)
packages/react/src/PricingOptions/PricingOptions.module.css:152
- The CSS custom property name uses inconsistent casing. It should be '--brand-pricing-options-items1-container-padding-inline' to match the established naming pattern used elsewhere in the file.
--brand-pricing-options-container-padding-inline: var(--brand-PricingOptions-items1-container-padding-inline);
packages/design-tokens/src/tokens/functional/components/pricing-options/pricing-options.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Rez <[email protected]>
...c.ts-snapshots/Visual-Comparison-PricingOptions-PricingOptions-Leading-Component-1-linux.png
Outdated
Show resolved
Hide resolved
@danielguillan FYI the docs example is broken for one pricing option. ![]() I think this is related to a bug where the Doctocat stylesheet is interfering with our local one. I have a fix, which I'll try to land ASAP. Should fix this bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Summary
Resolves https://github.com/github/primer/issues/5465. Updates the layout of single item pricing options to stack the content vertically and center align on large viewports.
What should reviewers focus on?
Steps to test:
Supporting resources (related issues, external links, etc):
Contributor checklist:
update snapshots
label to the PR)Reviewer checklist:
Screenshots: