-
Notifications
You must be signed in to change notification settings - Fork 53
Improves types in useTabs hook #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
joshfarrant
wants to merge
12
commits into
main
Choose a base branch
from
joshfarrant/use-tabs-type-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b77d5e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
🟢 No unit test coverage changes foundAll components with tests maintain the same coverage as the main branch. |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
59a671a
to
e3b05bb
Compare
…ndle the state updates
faf5fa0
to
b77d5e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ This is a follow-on PR from #1137. It will be rebased from main and marked as ready-for-review once that PR has been merged. It is also blocked by #1146 as that PR fixes a bug in the Tabs component where
aria-labelledby
wasn't being passed through to theuseTabs
hook.Summary
Improves types in
useTabs
hook, improvesuseTabs
tests, and fixes an accessibility issue in the IDE component which these type improvements automatically highlighted.List of notable changes
onClick
,onKeyDown
, andonFocus
typeslabel
orlabelledBy
is passed togetTabListProps()
focusTab
function to only focus the element and nothing else.onFocus
will handle the state updates. Previously two duplicate state updates were being triggered.@ts-expect-error
fromuseTabs.test.tsx
, now that the types are fixedlabel
to the tablist in the IDE component (thanks, TypeScript! 🎉)What should reviewers focus on?
useTabs
. There are no changes to functionality, just types.Steps to test
Supporting resources (related issues, external links, etc)
Contributor checklist
update snapshots
label to the PR)Reviewer checklist
Screenshots