Correct vertical alignment of FormControl validation icon

[joshfarrant]

Summary

Nudged the icon up 2px

What should reviewers focus on?

1. Does it look better?

Supporting resources (related issues, external links, etc):

• 🐛 [BUG] - Misalignment of icons in FormControl.Validation #650

Contributor checklist:

• All new and existing CI checks pass
• Tests prove that the feature works and covers both happy and unhappy paths
• Any drop in coverage, breaking changes or regressions have been documented above
• New visual snapshots have been generated / updated for any UI changes
• All developer debugging and non-functional logging has been removed
• Related issues have been referenced in the PR description

Reviewer checklist:

• Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
• Check that tests prove the feature works and covers both happy and unhappy paths
• Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before	After

[changeset-bot]

🦋 Changeset detected

Latest commit: 4577fce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@primer/react-brand	Patch
@primer/brand-primitives	Patch
@primer/brand-e2e	Patch
@primer/brand-fonts	Patch
@primer/brand-config	Patch
@primer/brand-storybook	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

🟢 No design token changes found

[github-actions]

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

[rezrah]

Looks a lot better now, thanks @joshfarrant.

The success variant is a little off... so is there anything more that can be done to improve alignment? No worries if there isn't, this is still better than what we have now.

[joshfarrant]

Thanks @rezrah. I'll modify the alignment on a per-icon basis and nudge the check slightly higher

[joshfarrant]

That's updated, good spot @rezrah.

How did you view it with the grid lines out of interest?

[rezrah]

That's updated, good spot @rezrah.

How did you view it with the grid lines out of interest?

There's a toolbar item in Storybook for enabling a grid. It's not perfect, but helpful in situations like this.

[rezrah]

Look much better, thanks @joshfarrant.

I think this regression occurred because we don't have dedicated stories for the validation states that are tracked in our VRT suite. If possible, could you please add some stories under FormControl enabling the validationStatus props for both success and error states. We'll then be able to see visual diffs in future.

[joshfarrant]

Good suggestion, thanks @rezrah

That's added, although the changes are fairly lost in the sea vrt spec files updates.

I'll rebase and get rid of those changes once #670 is in

EDIT: Rebased ✅