-
Notifications
You must be signed in to change notification settings - Fork 53
Update Storybook to 8.2.6 (latest), and move preview deploys to /brand #671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🟢 No design token changes found |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
d06e624
to
de77feb
Compare
2a21243
to
45f6920
Compare
e1f5cc7
to
bda43a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great 🙌
@joshfarrant - just two minor questions about dependency changes. Also could you please update the snapshots one more time to be sure there's no additional regressions with the latest changes please, seems like it hasn't run in a while.
Thanks @rezrah, I've responded to and resolved both comments I've been running the snapshot update in docker locally and all's good, but I've re-applied the label again just to be sure 👍 |
Summary
Update Storybook to latest, along with associated dependencies. Also moves preview deploys to live under /brand to match production.
List of notable changes:
7.6.17
to8.2.6
(latest).4.9.5
to5.5.4
(latest).27.5.1
to29.7.0
(latest)./brand
to more closely match production and make asset handling simpler in preview deploys.axe-clean.spec.ts
to use newindex.json
format instead of deprecatedstories.json
playwright.generate-tests.ts
to use newindex.json
format instead of deprecatedstories.json
*.visual.spec.ts
files. Because of this, it might be easier to view those changes in isolation when reviewing this PRWhat should reviewers focus on?
Steps to test:
Supporting resources (related issues, external links, etc):
Contributor checklist:
Reviewer checklist: