-
Notifications
You must be signed in to change notification settings - Fork 53
Add green-blue-purple
gradient color variant to Label
component
#889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add green-blue-purple
gradient color variant to Label
component
#889
Conversation
🦋 Changeset detectedLatest commit: e2feac3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔍 Design token changes foundView CSS variable changes+ --brand-Label-color-green-blue-purple-1: #000aff; + --brand-Label-color-green-blue-purple-2: #096bde; + --brand-Label-color-green-blue-purple-3: var(--base-color-scale-green-5); + --brand-Label-color-green-blue-purple-4: #8250df; + --brand-Label-color-green-blue-purple-3: #00ff46; + --brand-Label-color-green-blue-purple-4: #8250DF; + --brand-Label-color-green-blue-purple-3: var(--base-color-scale-green-5); + --brand-Label-color-green-blue-purple-2: #096BDE; + --brand-Label-color-green-blue-purple-1: #000AFF; |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
…llan/add-3-color-gradient-label
…thub.com/primer/brand into danielguillan/add-3-color-gradient-label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
.../react/src/IDE/IDE.visual.spec.ts-snapshots/Visual-Comparison-IDE-IDE-Playground-1-linux.png
Outdated
Show resolved
Hide resolved
c52f5f1
to
a5b6800
Compare
b714c52
to
e2feac3
Compare
Summary
Solves https://github.com/github/primer/issues/4583
List of notable changes:
green-blue-purple
option available for Labelcolor
.What should reviewers focus on?
Steps to test:
Contributor checklist:
update snapshots
label to the PR)Reviewer checklist:
Screenshots: