Skip to content

Conversation

danielguillan
Copy link
Contributor

@danielguillan danielguillan commented Jan 13, 2025

Summary

Solves https://github.com/github/primer/issues/4583

List of notable changes:

  • New green-blue-purple option available for Label color.

What should reviewers focus on?

Steps to test:

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: e2feac3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 13, 2025

🔍 Design token changes found

View CSS variable changes
+ --brand-Label-color-green-blue-purple-1: #000aff;
+ --brand-Label-color-green-blue-purple-2: #096bde;
+ --brand-Label-color-green-blue-purple-3: var(--base-color-scale-green-5);
+ --brand-Label-color-green-blue-purple-4: #8250df;
+ --brand-Label-color-green-blue-purple-3: #00ff46;
+ --brand-Label-color-green-blue-purple-4: #8250DF;
+ --brand-Label-color-green-blue-purple-3: var(--base-color-scale-green-5);
+ --brand-Label-color-green-blue-purple-2: #096BDE;
+ --brand-Label-color-green-blue-purple-1: #000AFF;

Copy link
Contributor

github-actions bot commented Jan 13, 2025

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@danielguillan danielguillan marked this pull request as ready for review February 11, 2025 11:37
@danielguillan danielguillan requested review from joshfarrant and removed request for rezrah February 27, 2025 09:53
Copy link
Contributor

@joshfarrant joshfarrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@joshfarrant joshfarrant force-pushed the danielguillan/add-3-color-gradient-label branch from c52f5f1 to a5b6800 Compare February 27, 2025 10:25
@danielguillan danielguillan force-pushed the danielguillan/add-3-color-gradient-label branch from b714c52 to e2feac3 Compare February 27, 2025 12:07
@danielguillan danielguillan merged commit 34e444e into main Feb 27, 2025
17 checks passed
@danielguillan danielguillan deleted the danielguillan/add-3-color-gradient-label branch February 27, 2025 13:56
@primer-css primer-css mentioned this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants