ActionMenu falsy value bugfix #912
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes check for truthiness in
handleItemSelection
inActionMenu.tsx
to allow falsy values to trigger item selection callback.List of notable changes:
ActionMenu.tsx
: Removed check for truthiness inhandleItemSelection
to allow falsy values to trigger item selection callback.ActionMenu.test.tsx
: Added a test to assert that falsy items can be selectedSteps to test:
""
onSelect
callback is called and triggers an alert.Supporting resources (related issues, external links, etc):
Contributor checklist:
update snapshots
label to the PR)Reviewer checklist: