Skip to content

Fix missing CSS namespace on active IDE tab class #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 6, 2025
Merged

Fix missing CSS namespace on active IDE tab class #917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e7aaae
fix missing namespce on active IDE active tab class
rezrah Feb 3, 2025
b8ff8b4
regen types
rezrah Feb 3, 2025
3b08387
fix merge conflcit
rezrah Jun 6, 2025
27de2dd
update changeset
rezrah Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/neat-singers-rest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react-brand': patch
---

Internal change to CSS module type definitions in the `IDE` component. No user-facing updates to `IDE` presentation or functionality are expected.
8 changes: 4 additions & 4 deletions packages/react/src/IDE/IDE.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,13 +212,13 @@
background: var(--brand-IDE-glass-editor-tab-bgColor-rest);
}

.IDE__Editor-tab.active {
.IDE__Editor-tab--active {
color: var(--brand-color-text-default);
border-top: var(--brand-borderWidth-thin) solid var(--brand-IDE-default-editor-tab-borderColor);
z-index: 1;
}

.IDE--default .IDE__Editor-tab.active {
.IDE--default .IDE__Editor-tab--active {
background: var(--brand-IDE-default-editor-tab-bgColor-active);
}

Expand All @@ -227,12 +227,12 @@
color: var(--brand-color-text-subtle);
}

.IDE--glass .IDE__Editor-tab.active {
.IDE--glass .IDE__Editor-tab--active {
color: var(--brand-color-text-default);
background: var(--brand-IDE-glass-editor-tab-bgColor-active);
}

.IDE--full-exp.IDE--glass .IDE__Editor-tab.active {
.IDE--full-exp.IDE--glass .IDE__Editor-tab--active {
background: var(--brand-IDE-default-editor-bgColor);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/IDE/IDE.module.css.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@ declare const styles: {
readonly "IDE__Editor-pane--suggested": string;
readonly "IDE__Editor-replay": string;
readonly "IDE__Editor-tab": string;
readonly "IDE__Editor-tab--active": string;
readonly "IDE__Editor-tab-close-icon": string;
readonly "IDE__Editor-tab-icon": string;
readonly "IDE__Editor-tabs": string;
readonly "IDE__inner": string;
readonly "IDE__main": string;
readonly "active": string;
};
export = styles;

2 changes: 1 addition & 1 deletion packages/react/src/IDE/IDE.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ const _Editor = memo(
<button
{...tabs.getTabProps(index.toString())}
key={file.name}
className={clsx(styles['IDE__Editor-tab'], isActiveTab && styles.active)}
className={clsx(styles['IDE__Editor-tab'], isActiveTab && styles['IDE__Editor-tab--active'])}
>
{language && (
<img
Expand Down
Loading