Perform seach in the background #178
Merged
+93
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). doctocat – ./🔍 Inspect: https://vercel.com/primer/doctocat/r8e4900t6 gatsby-theme-primer-example – ./🔍 Inspect: https://vercel.com/primer/gatsby-theme-primer-example/dblzep6k8 |
colebemis
approved these changes
Sep 15, 2020
|
Thanks for doing this @BinaryMuse! We just pulled this change into docs.npmjs.com which uses a fork of doctocat. 🎉 npm/feedback#78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we run a Fuse query on the main thread when the user enters a search term. This causes a lot of GC and some page jank.
This PR moves the Fuse search into the background via web workers. In my testing, this reduced event handler run time from hundreds of milliseconds to around 10.