Skip to content

Conversation

rezrah
Copy link
Contributor

@rezrah rezrah commented May 30, 2022

Added support for Figma links to mdx frontmatter.

Screenshot 2022-05-30 at 12 09 46

Optional link support added in similar way to existing GitHub source code and Storybook links. This is needed for Primer Brand, where we want to link to external Figma design files for supplementary content.

External links in the frontmatter open in new tabs.

  • Closes Storybook links open incorrect Story in docs react#2047
  • Provides a better user experience for Storybook and other external content
    • Storybook creates two new entries to the History stack when loading Storybook: / and /?path-to-story. This means you need to double-press the back button to get back to docs whereas the user would have assumed it was one.

@rezrah rezrah requested a review from colebemis May 30, 2022 11:52
@changeset-bot
Copy link

changeset-bot bot commented May 30, 2022

🦋 Changeset detected

Latest commit: 03bf416

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/gatsby-theme-doctocat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rezrah rezrah temporarily deployed to github-pages May 30, 2022 11:58 Inactive
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖

@rezrah rezrah temporarily deployed to github-pages July 25, 2022 13:43 Inactive
@rezrah rezrah merged commit 1e22900 into main Jul 25, 2022
@rezrah rezrah deleted the rezrah/new-window-frontmatter-links branch July 25, 2022 13:49
@primer-css primer-css mentioned this pull request Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook links open incorrect Story in docs
2 participants