Skip to content

Spacing and navigation fixes #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 21, 2023
Merged

Spacing and navigation fixes #610

merged 5 commits into from
Jul 21, 2023

Conversation

josepmartins
Copy link
Contributor

@josepmartins josepmartins commented Jul 20, 2023 •
edited
Loading

Fixes minor visual issues

  • Aligned with @kendallgassner we could safely move the heading out of the sidebar Navigation. This fixes the extra divider on top of the navigation.
Before After
Screenshot 2023-07-20 at 18 26 02 Screenshot 2023-07-20 at 18 25 53
  • Remove extra space below the heading when there's no status or external links
Before After
Screenshot 2023-07-20 at 18 03 15 Screenshot 2023-07-20 at 18 30 36
  • Remove extra space when there's no Breadcrumbs
Before After
Screenshot 2023-07-20 at 17 53 53 Screenshot 2023-07-20 at 18 30 36

@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 107cfc9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/gatsby-theme-doctocat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@josepmartins josepmartins temporarily deployed to github-pages July 20, 2023 16:29 — with GitHub Actions Inactive
@josepmartins josepmartins marked this pull request as ready for review July 20, 2023 16:31
@josepmartins josepmartins changed the title Josepmartins/layout fixes Spacing and navigation fixes Jul 20, 2023
@josepmartins josepmartins temporarily deployed to github-pages July 20, 2023 16:33 — with GitHub Actions Inactive
@josepmartins josepmartins self-assigned this Jul 20, 2023
kendallgassner
kendallgassner approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@kendallgassner kendallgassner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@josepmartins josepmartins merged commit ba972b1 into main Jul 21, 2023
@josepmartins josepmartins deleted the josepmartins/layout-fixes branch July 21, 2023 06:50
@primer-css primer-css mentioned this pull request Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kendallgassner kendallgassner kendallgassner approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti

+1 more reviewer

@emilybrick emilybrick emilybrick approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@josepmartins josepmartins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josepmartins @emilybrick @kendallgassner