Skip to content

Conversation

lukasoppermann
Copy link
Collaborator

Summary

Change primitives.css to use imports and add viewport.css

This is one step in https://github.com/github/primer/issues/4506

@langermank is there any reason you removed viewports from primer.css? It is added in dotcom in the index.scss

List of notable changes:

What should reviewers focus on?

Steps to test:

@Copilot Copilot AI review requested due to automatic review settings August 26, 2025 09:34
@lukasoppermann lukasoppermann requested review from a team as code owners August 26, 2025 09:34
Copy link

changeset-bot bot commented Aug 26, 2025

🦋 Changeset detected

Latest commit: 643dbe1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the CSS build system to use imports in primitives.css and re-enables viewport.css. The change simplifies CSS loading by consolidating multiple imports into a single primitives.css file and restores viewport styles that were previously excluded.

  • Modified build script to generate import statements instead of concatenating CSS content
  • Re-enabled viewport.css by commenting out its exclusion filter
  • Updated Storybook preview to use the consolidated primitives.css import

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
scripts/buildTokens.ts Modified to generate CSS imports and re-enable viewport.css in the build
docs/storybook/.storybook/preview.css Simplified to use single primitives.css import instead of multiple individual imports

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot temporarily deployed to Preview (Storybook) August 26, 2025 09:37 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant