Skip to content

feat: add InlineMessage component #4443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Jun 11, 2024
Merged

feat: add InlineMessage component #4443

merged 28 commits into from
Jun 11, 2024

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Mar 27, 2024 •
edited
Loading

Context https://github.com/github/primer/issues/3319

Changelog

New

  • Add InlineMessage component

Changed

Removed

Rollout strategy

  • Minor release

Testing & Reviewing

  • Verify component appearance and behavior based on usage docs
  • Evaluate component API, provide feedback if something is misaligned with system expectations

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Storybook)
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: d642a62

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joshblack joshblack added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Mar 27, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4443 March 27, 2024 15:39 Inactive
@joshblack joshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 27, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4443 March 27, 2024 15:45 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 27, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4443 March 27, 2024 15:51 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 27, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.45 KB (0%)
packages/react/dist/browser.umd.js 89.79 KB (0%)

@joshblack joshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 27, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4443 March 27, 2024 20:00 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 27, 2024
@primer primer bot temporarily deployed to github-pages March 27, 2024 20:07 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4443 March 27, 2024 20:08 Inactive
@joshblack joshblack closed this Apr 12, 2024
@joshblack joshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jun 10, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4443 June 10, 2024 20:55 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jun 10, 2024
@primer primer bot temporarily deployed to github-pages June 10, 2024 21:02 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4443 June 10, 2024 21:02 Inactive
@lukasoppermann lukasoppermann mentioned this pull request Jun 11, 2024
Merged
@joshblack joshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jun 11, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4443 June 11, 2024 14:18 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jun 11, 2024
langermank
langermank approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so good! ✨

@joshblack joshblack added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit f252337 Jun 11, 2024
@joshblack joshblack deleted the feat/add-inline-message branch June 11, 2024 14:53
@primer primer bot mentioned this pull request Jun 11, 2024
Merged
@StemmlerSisters StemmlerSisters mentioned this pull request Jul 16, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jul 17, 2024
Open
@julitabarelkowska julitabarelkowska mentioned this pull request Jul 17, 2024
Open
@Canadatechmanufacturing Canadatechmanufacturing mentioned this pull request Jul 17, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 13, 2024
Open
@Mapuppy09 Mapuppy09 mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasoppermann lukasoppermann lukasoppermann approved these changes

@langermank langermank langermank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @langermank @lukasoppermann