Skip to content

Add aria-expanded back to AnchoredOverlay #4456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 6, 2024
Merged

Add aria-expanded back to AnchoredOverlay #4456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8ea6a27
Adds `aria-expanded="false"` back to `AnchoredOverlay`
TylerJDev Mar 14, 2024
7cc9d42
Add changeset
TylerJDev Mar 14, 2024
fe602a3
Merge branch 'main' into add-aria-expanded-state-take-two
TylerJDev Apr 2, 2024
5ce6edf
Merge branch 'main' into add-aria-expanded-state-take-two
TylerJDev Apr 4, 2024
3da3953
Merge branch 'main' into add-aria-expanded-state-take-two
TylerJDev Apr 11, 2024
0d6dee4
Merge branch 'main' into add-aria-expanded-state-take-two
TylerJDev Apr 24, 2024
00a2f52
Merge branch 'main' into add-aria-expanded-state-take-two
TylerJDev May 6, 2024
2c5ea1d
Merge branch 'main' into add-aria-expanded-state-take-two
TylerJDev May 6, 2024
afab486
Merge branch 'main' into add-aria-expanded-state-take-two
TylerJDev May 7, 2024
4b4e4ff
Merge branch 'main' into add-aria-expanded-state-take-two
TylerJDev May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/chatty-phones-admire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Adds full `aria-expanded` (true/false) state to `AnchoredOverlay`, and components that consume it
2 changes: 1 addition & 1 deletion packages/react/src/AnchoredOverlay/AnchoredOverlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ export const AnchoredOverlay: React.FC<React.PropsWithChildren<AnchoredOverlayPr
ref: anchorRef,
id: anchorId,
'aria-haspopup': 'true',
'aria-expanded': open ? 'true' : undefined,
'aria-expanded': open,
tabIndex: 0,
onClick: onAnchorClick,
onKeyDown: onAnchorKeyDown,
Expand Down