ActionBar: Add new component for submenu #4462
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 366d598 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
siddharthkp
reviewed
Apr 16, 2024
| @@ -13,7 +13,8 @@ import {useOnOutsideClick} from '../../hooks/useOnOutsideClick' | |||
| import type {IconButtonProps} from '../../Button' | |||
| import {IconButton} from '../../Button' | |||
| import Box from '../../Box' | |||
| import {ActionMenu} from '../..' | |||
| import {ActionMenu} from '../../ActionMenu' | |||
| import {Action} from 'history' | |||
siddharthkp
approved these changes
Apr 16, 2024
|
I'm still waiting for this PR to get merged for this one to be viable.#4486 |
|
Removing myself from the reviewers for now, feel free to add back in when the manage to merge back the nested menus 🙌🏻 |
|
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #https://github.com/github/primer/issues/3132
This makes use of new capability in ActionMenu to have Submenus. We can use it to make sure that menus are supported with IconButton trigger in the ActionBar. The intent is to be able to convert it into a SubMenu when the overflow behaviour kicks in.
New
Screen.Recording.2024-04-04.at.1.17.10.PM.mov
Rollout strategy
Testing & Reviewing
Check out the new submenu story.
Merge checklist