Skip to content

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Jul 19, 2024

Changelog

<dialog> ships with a default browser style (color: canvastext) that need to be overwritten to work across our themes

Before After
before, text barely visible after, text now clearly visible

Rollout strategy

  • Patch release

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Jul 19, 2024

🦋 Changeset detected

Latest commit: b3ceb77

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddharthkp siddharthkp requested a review from joshblack July 19, 2024 13:08
@github-actions github-actions bot added the staff Author is a staff member label Jul 19, 2024
@siddharthkp siddharthkp self-assigned this Jul 19, 2024
@siddharthkp siddharthkp marked this pull request as ready for review July 19, 2024 13:10
@siddharthkp siddharthkp requested a review from a team as a code owner July 19, 2024 13:10
Copy link
Contributor

github-actions bot commented Jul 19, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.42 KB (0%)
packages/react/dist/browser.umd.js 92.68 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4757 July 19, 2024 13:16 Inactive
@siddharthkp siddharthkp added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 22, 2024
@primer primer bot requested a review from a team as a code owner July 22, 2024 08:34
@primer primer bot requested a review from mperrotti July 22, 2024 08:34
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants