Skip to content

Conversation

pksjce
Copy link
Contributor

@pksjce pksjce commented Aug 25, 2025

Closes https://github.com/github/primer/issues/5122

Changelog

Breadcrumbs now show an overflow menu with the following features

  • If no of items in the breadcrumbs is >5 then we show the menu
  • If the screen width can't accomodate the items then we show the menu
  • if overflow==="menu-with-root" show the root item.

https://www.loom.com/share/8902798416b741c9959fc7bb501185a5

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@Copilot Copilot AI review requested due to automatic review settings August 25, 2025 11:48
@pksjce pksjce requested a review from a team as a code owner August 25, 2025 11:48
@pksjce pksjce requested a review from francinelucca August 25, 2025 11:48
Copy link

changeset-bot bot commented Aug 25, 2025

🦋 Changeset detected

Latest commit: 71753ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Patch
@primer/styled-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Aug 25, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copilot

This comment was marked as spam.

Copy link
Contributor

github-actions bot commented Aug 25, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.54 KB (+1.02% 🔺)
packages/react/dist/browser.umd.js 89.66 KB (+1.05% 🔺)

@pksjce
Copy link
Contributor Author

pksjce commented Sep 8, 2025

@joshblack - I have created this issue for the Esc button bug. It emerged because I made the IconButton of as summary.
Thanks for catching it. Will fix it separately

Copy link
Member

@strackoverflow strackoverflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing!

@pksjce pksjce added the integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh label Sep 10, 2025
@pksjce pksjce enabled auto-merge September 10, 2025 05:03
@francinelucca francinelucca removed their request for review September 10, 2025 14:29
@pksjce pksjce disabled auto-merge September 11, 2025 22:03
@pksjce pksjce added this pull request to the merge queue Sep 11, 2025
Merged via the queue into main with commit 2910207 Sep 11, 2025
46 checks passed
@pksjce pksjce deleted the pk/breadcrumbs-with-overflow-menu branch September 11, 2025 22:10
@primer primer bot mentioned this pull request Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants