Banner: Should prefer aria-labelled-by over aria-label

[pksjce]

Part of https://github.com/github/primer/issues/5628

During a migration effort on github-ui, I found that a test there was failing due to Banner setting both aria-labelled-by and aria-label

Changelog

New

Changed

Removed

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

🦋 Changeset detected

Latest commit: eeba853

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@primer/react	Patch
@primer/styled-react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Copilot]

Pull Request Overview

This PR fixes an accessibility issue in the Banner component by implementing proper precedence for aria labeling attributes. When both aria-labelledby and aria-label are provided, the component now prioritizes aria-labelledby and conditionally sets aria-label only when aria-labelledby is not present.

• Adds support for aria-labelledby prop extraction and conditional aria attribute setting
• Implements proper accessibility precedence where aria-labelledby takes priority over aria-label
• Adds comprehensive test coverage for the new labeling behavior

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
packages/react/src/Banner/Banner.tsx	Extracts aria-labelledby prop and implements conditional logic to prevent both aria attributes from being set simultaneously
packages/react/src/Banner/Banner.test.tsx	Adds test cases to verify proper aria attribute precedence and that only one labeling method is used at a time

[github-actions]

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	89.83 KB (0%)
packages/react/dist/browser.umd.js	90 KB (0%)

[pksjce]

The failure in the integration tests is unrelated to this PR and I'm investigating it separately.

[primer-integration]

😢 Hi from github/github-ui. The integration workflow has failed: https://github.com/github/github-ui/actions/runs/17419544075