-
Notifications
You must be signed in to change notification settings - Fork 174
Fix: Replace duplicate callout headings with ARIA-labeled sections #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This PR looks good. |
Thank you for the feedback! Please let me know if there's anything else you'd like me to update. Otherwise, I’ll wait for the merge whenever it fits your timeline. |
Hi @coseeian, |
Hi @perminder-17 , could you please review my PR? |
Thanks for your work @reshma045. I'll have a look today in few hours. Thanks for your patience 🙂 |
Hi @reshma045 , thanks for your work on this and your patience! Some minor points that I think could be improved. Rather than inline css, a class would be preferred in general; however, in this case, looks like the semantic heading |
Thank you for your feedback, @ksen0! Yes, preserving the semantic value of |
That sounds good @reshma045 , thanks! |
Hi @reshma045 , could you confirm if you're still working on this one please? If there is no response in 7 days, we can also work on wrapping it up. If you need more time, it's no problem at all, but just to confirm that you're still intending to finish this. Thanks so much for all your work on this! |
Description
This PR addresses issue #871 by replacing repeated heading elements (
<h5>Tip</h5>
,<h5>Note</h5>
, etc.) used in callout blocks with<section>
elements that include accessible ARIA labels instead.Changes Made
src/components/callout/index.astro
:<h5>
heading with<section role="region" aria-label="...">
Before vs After
<h5>Tip</h5>
or<h5>Note</h5>
headings were present, cluttering the document structure and affecting accessibility.<section aria-label="Tip">...</section>
and similar, improving semantic clarity and screen reader navigation.Screenshot
Before

After

Related Issue
Closes #871