Add missing translations for tutorial section headings #931
Conversation
|
Hiii! @ksen0 just wanted to kindly ask if you could take a look at my pull request , It took me quite a while to go through each of the missing translations across all four languages (Hindi, Spanish, Korean, and Simplified Chinese), and make sure everything is rendering correctly. Would really appreciate your feedback or review whenever you have time. Thanks a lot! |
|
Thanks for putting this together @Homaid ! To merge this one, it would be great to get at least one review of each of the languages. I'm tagging below the i18n stewards and the volunteers from processing/p5.js-web-editor#3578 - if you have time, please review the content of each of the languages carefully, and provide suggestions for improvement - or confirm that the translations work well for the website! Korean - @jungmokyi Thanks in advance, everyone. |
src/content/ui/zh-Hans.yaml
Outdated
| webgl: "WebGL" | ||
| "advanced": "高级主题" | ||
| criticalAI: " 批判性人工智能" | ||
| webgl: "网页图形库" |
There was a problem hiding this comment.
In Chinese we don't translate proper nouns such as library names, so I’d like to keep it as WebGL.
src/content/ui/hi.yaml
Outdated
| introduction: "p5.js का परिचय" | ||
| drawing: "चित्रण" | ||
| web-design: "वेब डिज़ाइन" | ||
| accessibility: "सुलभता" |
There was a problem hiding this comment.
Please use "अभिगम्यता" here
src/content/ui/hi.yaml
Outdated
| web-design: "वेब डिज़ाइन" | ||
| accessibility: "सुलभता" | ||
| criticalAI: "क्रिटिकल AI" | ||
| webgl: "वेबग्ल" |
There was a problem hiding this comment.
we should do "वेबजीएल" instead of "वेबग्ल".
src/content/ui/hi.yaml
Outdated
| web-design: "वेब डिज़ाइन" | ||
| accessibility: "सुलभता" | ||
| criticalAI: "क्रिटिकल AI" | ||
| webgl: "वेबग्ल" |
There was a problem hiding this comment.
| webgl: "वेबग्ल" | |
| webgl: "वेबजीएल" |
src/content/ui/hi.yaml
Outdated
| introduction: "p5.js का परिचय" | ||
| drawing: "चित्रण" | ||
| web-design: "वेब डिज़ाइन" | ||
| accessibility: "सुलभता" |
There was a problem hiding this comment.
| accessibility: "सुलभता" | |
| accessibility: "अभिगम्यता" |
src/content/ui/zh-Hans.yaml
Outdated
| @@ -97,10 +97,11 @@ tutorialCategories: | |||
| drawing: "绘图" | |||
| "web-design": "网页设计" | |||
| accessibility: "无障碍" | |||
| webgl: "WebGL" | |||
| "advanced": "高级主题" | |||
| criticalAI: " 批判性人工智能" | |||
There was a problem hiding this comment.
| criticalAI: " 批判性人工智能" | |
| criticalAI: "批判性人工智能" |
There was a problem hiding this comment.
Just a quick heads up -> noticed the inconsistency while reviewing; in the translation keys across the YAML files:
"web-design": has quotes
education-resources: missing quotes
"advanced": has quotes
Should we standardize this? since keys with hyphens usually need quotes.
There was a problem hiding this comment.
hey @adi-ray I noticed the mix too some keys are quoted, some are not. I kept the same style as the original files I edited to avoid unrelated changes
There was a problem hiding this comment.
@perminder-17 @Homaid @adi-ray @ksen0
I think the quotes create issues that go beyond consistency.
Issue identified: YAML values with quotes are not being processed correctly by the template engine.
From live website:
- Working translations (no quotes): Main content renders correctly in es/ko/hi/zh-Hans
- Broken translations (with quotes): Tutorial sidebar categories remain in English only
The tutorialCategories section is using quoted values while other working sections use unquoted values. This suggests the p5.js template engine has a parsing issue with quoted YAML strings.
Proposed solution: Remove quotes from all tutorialCategories values.
Request: I can submit a follow-up PR with the fix. Should I proceed with this?
@marioguzzzman - I can take ownership of the Spanish translation fixes going forward.
|
Hi @ksen0 I’ve made the edits based on the review comments. The pr is now updated with changes Thank you so much! |
src/content/ui/ko.yaml
Outdated
| web-design: "웹 디자인" | ||
| accessibility: "접근성" | ||
| criticalAI: "비판적 AI" | ||
| webgl: "웹글" |
There was a problem hiding this comment.
I suggest "웹지엘" or just leaving it as WebGL
|
Hi everyone, thanks so much for your review and input. At the moment, we don’t have a dedicated steward for Korean translations. @hana-cho, would you be interested in taking on this role? If so, we’d be happy to tag you in the future for Korean translation reviews and guidance. Also, sorry I missed getting a Spanish review before merging. If anyone is available, could you please review the Spanish section and share any fixes? I’ll coordinate a follow-up PR with the contributor for any changes, and we can cherry-pick the resulting updates as needed? cc: @marioguzzzman, |
|
@perminder-17 Yes, I would love to! |
- Removes quotes from YAML values to fix template engine parsing - Resolves sidebar translation issue where categories stayed in English - Fixes follow-up from PR processing#931"
Summary
This PR adds missing
tutorialCategoriestranslations to the following UI locale files:hi.yaml(Hindi)es.yaml(Spanish)ko.yaml(Korean)zh-Hans.yaml(Chinese)Details
The following keys were missing and have now been added:
webglweb-desgindrawingaccessibilityadvanced-topicscriticalAIeducation-resourcesThis fixes the issue where some tutorial section headers were still appearing in English instead of the selected language.
Related Issue
Closes #930
Testing
Tested locally by switching the site language to all four and verifying that all tutorial section headers are now properly translated.
Let me know if anything else needs to be adjusted. Thanks!