Skip to content

Conversation

shawdm
Copy link
Contributor

@shawdm shawdm commented Jul 27, 2025

Resolves documentation issue: 7986

PR Checklist

@davepagurek
Copy link
Contributor

It looks like we accidentally had it backwards for bezierPoint and curvePoint, as curvePoint calls its inner points controls when those are actually the anchors:

* @method curvePoint
* @param {Number} a coordinate of first anchor point.
* @param {Number} b coordinate of first control point.
* @param {Number} c coordinate of second control point.
* @param {Number} d coordinate of second anchor point.
* @param {Number} t amount to interpolate between 0 and 1.
* @return {Number} coordinate of a point on the curve.

Mind flipping the terminology there too?

@shawdm
Copy link
Contributor Author

shawdm commented Jul 27, 2025

It looks like we accidentally had it backwards for bezierPoint and curvePoint, as curvePoint calls its inner points controls when those are actually the anchors:

* @method curvePoint
* @param {Number} a coordinate of first anchor point.
* @param {Number} b coordinate of first control point.
* @param {Number} c coordinate of second control point.
* @param {Number} d coordinate of second anchor point.
* @param {Number} t amount to interpolate between 0 and 1.
* @return {Number} coordinate of a point on the curve.

Mind flipping the terminology there too?

Done.

@davepagurek
Copy link
Contributor

Thanks @shawdm!

@davepagurek davepagurek merged commit ef2f4e6 into processing:main Jul 27, 2025
2 checks passed
@davepagurek
Copy link
Contributor

Is this also an issue in the beta.p5js.org docs? If so, would you also be interested in opening a PR into the dev-2.0 branch with the same changes?

@davepagurek
Copy link
Contributor

@all-contributors please add @shawdm for doc

Copy link
Contributor

@davepagurek

I've put up a pull request to add @shawdm! 🎉

@shawdm
Copy link
Contributor Author

shawdm commented Jul 27, 2025

Is this also an issue in the beta.p5js.org docs? If so, would you also be interested in opening a PR into the dev-2.0 branch with the same changes?

Thanks. Will check beta.p5js.org too and put in a PR if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants